Use single instance of CWalletDB in CSparkWallet

psolstice commented 1 year ago

PR intention

Performance optimization by using single instance of CWalletDB

Code changes brief

This is a first step in a refactor that strongly binds CWallet/CSparkWalletandCWalletDB` together

Summary by CodeRabbit

New Features
- Enhanced support for handling multiple wallets, improving user flexibility and management of different wallets.
- Streamlined wallet operations, including initialization, shutdown, and database recovery, for better performance and reliability.
- Added new verification functions for wallet databases, ensuring integrity and security.
Refactor
- Updated wallet handling logic to accommodate multiple wallets seamlessly.
- Simplified database interactions in wallet functions, reducing redundancy and enhancing efficiency.
- Refactored wallet database code to improve transaction control and data writing/erasing processes.
Bug Fixes
- Fixed issues in wallet shutdown process to ensure clean wallet closure and data preservation.
- Addressed wallet database recovery procedures to handle potential errors more effectively.
Documentation
- Updated internal documentation to reflect changes in wallet handling and database operations.

levonpetrosyan93 commented 1 year ago

@psolstice Please rebase onto spark_ branch

coderabbitai[bot] commented 7 months ago

Walkthrough

The recent updates focus on enhancing wallet management and database recovery within a cryptocurrency framework. Key changes include support for multiple wallets, streamlined wallet database operations, and improved error handling. The modifications span across initialization, shutdown processes, and wallet interaction mechanisms, aiming to refine the system's robustness and efficiency.

Changes

Files	Change Summary
`src/init.cpp`, `src/qt/bitcoin.cpp`, `src/wallet/rpcwallet.cpp`, `src/wallet/test/...`, `src/wallet/wallet.cpp`, `src/wallet/wallet.h`	Enhanced support for multiple wallets, including adjustments in wallet initialization, shutdown, and RPC interactions.
`src/spark/sparkwallet.cpp`, `src/spark/sparkwallet.h`	Refactored `CSparkWallet`, improved database operation efficiency by eliminating redundant operations, and updated function signatures.
`src/util.cpp`, `src/wallet/db.cpp`, `src/wallet/db.h`, `src/wallet/walletdb.cpp`, `src/wallet/walletdb.h`	Improved database recovery and verification processes, added functionality for environment and file verification, and updated data writing and erasing methods to include update counter incrementation.

Poem

In the realm of code, where changes abound,
A rabbit hopped in, leaving footprints on the ground.
With a flick and a hop, wallets multiple it sought,
Streamlining the data, with efficiency it brought.
🐇💾 Through bits and through bytes, it danced with delight,
"To improve and refine," it whispered to the night.
So here's to the changes, may they make systems bright!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

firoorg / firo