firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

building depends fails on Fedora #1240

Closed erciccione closed 1 year ago

erciccione commented 1 year ago

Describe the issue

I'm trying to build on Fedora 37 following these instructions: https://github.com/firoorg/firo#build-firo and trying to build using the second option (with GUI wallet).

After i cd into the depends folder and run make, the build fails with this error:

checking for libevent directory... configure: WARNING: Could not find a linkable libevent.  If you have it installed somewhere unusual, you can specify an explicit path using --with-libevent-dir
configure: WARNING: On Fedora, you can install libevent using "dnf install libevent"
configure: WARNING:    You will probably need to install libevent-devel too.
configure: error: Missing libraries; unable to proceed.
make: *** [funcs.mk:283: firo/firo/depends/work/build/x86_64-pc-linux-gnu/tor/0.4.7.7-16f6f2781b4/./.stamp_configured] Error 1

both libevent and libevent-devel are correctly installed.

justanwar commented 1 year ago

Do you have the config.log from the directory where tor was built?

erciccione commented 1 year ago

I have it. Any particular part that you want to see? I could show all of it, but i will need to redact it first, since it contains extensive information about my local system.

psolstice commented 1 year ago

Most important info is the information regarding compiler flags that were used to compile the unit that failed. Normally config.log doesn't contain a lot of sensitive info (though in some rare cases it can). Also it'd be useful to know if environment variables for compilation set to non-empty values (CFLAGS, CXXFLAGS, LDFLAGS etc). And of course the compiler error message is important.

erciccione commented 1 year ago

@psolstice probably easier if i send you the full log privately. What's the better way to contact you?

psolstice commented 1 year ago

@erciccione peter at firo dot org

erciccione commented 1 year ago

Email sent

psolstice commented 1 year ago

Please try to build the branch named libevent-upgrade to see if it fixes the problem

erciccione commented 1 year ago

Please try to build the branch named libevent-upgrade to see if it fixes the problem

Sadly still fails:

[ 94%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fpx_mul_low.c.o
[ 95%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fpx_rdc_low.c.o
[ 95%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fpx_sqr_low.c.o
[ 96%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/gmp/relic_fb_add_low.c.o
[ 96%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_inv_low.c.o
[ 96%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_itr_low.c.o
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fpx_sqr_low.c:128:25: warning: argument 1 of type ‘dig_t[3][34]’ {aka ‘long unsigned int[3][34]’} with mismatched bound [-Warray-parameter=]
  128 | void fp3_sqrn_low(dv3_t c, fp3_t a) {
      |                   ~~~~~~^
In file included from ...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fpx_sqr_low.c:34:
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/low/relic_fpx_low.h:370:25: note: previously declared as ‘dig_t[2][34]’ {aka ‘long unsigned int[2][34]’}
  370 | void fp3_sqrn_low(dv2_t c, fp3_t a);
      |                   ~~~~~~^
[ 97%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_rdc_low.c.o
[ 97%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_mul_low.c.o
[ 98%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/gmp/relic_fb_shift_low.c.o
[ 98%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_slv_low.c.o
[ 98%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_sqr_low.c.o
[ 99%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_srt_low.c.o
[ 99%] Building C object _deps/relic-build/src/CMakeFiles/relic_s.dir/low/easy/relic_fb_trc_low.c.o
In file included from ...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_mul_low.c:34:
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_mul_low.c: In function ‘fb_mulm_low’:
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:263:33: warning: ‘fb_rdc_quick’ accessing 272 bytes in a region of size 80 [-Wstringop-overflow=]
  263 | #define fb_rdc(C, A)            fb_rdc_quick(C, A)
      |                                 ^~~~~~~~~~~~~~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_mul_low.c:230:9: note: in expansion of macro ‘fb_rdc’
  230 |         fb_rdc(c, t);
      |         ^~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:263:33: note: referencing argument 2 of type ‘dig_t[34]’ {aka ‘long unsigned int[34]’}
  263 | #define fb_rdc(C, A)            fb_rdc_quick(C, A)
      |                                 ^~~~~~~~~~~~~~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_mul_low.c:230:9: note: in expansion of macro ‘fb_rdc’
  230 |         fb_rdc(c, t);
      |         ^~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:782:6: note: in a call to function ‘fb_rdc_quick’
  782 | void fb_rdc_quick(fb_t c, dv_t a);
      |      ^~~~~~~~~~~~
In file included from ...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_sqr_low.c:32:
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_sqr_low.c: In function ‘fb_sqrm_low’:
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:263:33: warning: ‘fb_rdc_quick’ accessing 272 bytes in a region of size 80 [-Wstringop-overflow=]
  263 | #define fb_rdc(C, A)            fb_rdc_quick(C, A)
      |                                 ^~~~~~~~~~~~~~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_sqr_low.c:163:9: note: in expansion of macro ‘fb_rdc’
  163 |         fb_rdc(c, t);
      |         ^~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:263:33: note: referencing argument 2 of type ‘dig_t[34]’ {aka ‘long unsigned int[34]’}
  263 | #define fb_rdc(C, A)            fb_rdc_quick(C, A)
      |                                 ^~~~~~~~~~~~~~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/src/low/easy/relic_fb_sqr_low.c:163:9: note: in expansion of macro ‘fb_rdc’
  163 |         fb_rdc(c, t);
      |         ^~~~~~
...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/_deps/relic-src/include/relic_fb.h:782:6: note: in a call to function ‘fb_rdc_quick’
  782 | void fb_rdc_quick(fb_t c, dv_t a);
      |      ^~~~~~~~~~~~
[100%] Linking C static library ../lib/librelic_s.a
make[3]: Leaving directory '...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build'
[100%] Built target relic_s
make[2]: Leaving directory '...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build'
make[1]: *** [Makefile:130: all] Error 2
make[1]: Leaving directory '...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build'
make: *** [funcs.mk:282: ...firo/firo/depends/work/build/x86_64-pc-linux-gnu/bls-dash/1.1.0-5f2a21fa358/build/.stamp_built] Error 2
erciccione commented 1 year ago

Side note: I tried to build depends inside a docker container running Ubuntu 22.04 and had no issues.

psolstice commented 1 year ago

Ok, thanks for the feedback! I will try to do Fedora build myself

erciccione commented 1 year ago

Same error when trying to run precompiled binaries. I opened a dedicated issue #1247

psolstice commented 1 year ago

I've fixed some error with depends build (see libevent-upgrade branch). But because a lot has changed in depends the daemon now can't be built, I'm in progress of fixing it. Will take a look at binary problem Thanks for reporting a problem!

psolstice commented 1 year ago

Please try this one https://github.com/firoorg/firo/pull/1250

justanwar commented 1 year ago

Fixed in #1250