firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Certain transactions not locked by InstantSend on testnet #1298

Closed justanwar closed 1 year ago

justanwar commented 1 year ago

image

On testnet it appears that some transactions are not InstantSend-locked even after the transaction in question has exited Dandelion.

IS-Locked:

Not IS-locked:

justanwar commented 1 year ago

Created 10 transparent-to-transparent transactions within a short period of time. All were InstantSend-locked.

nrsimha commented 1 year ago

Not sure if this is related to this or if I should create new issue.

I made transactions to Lucas during today event and now after almost 1 hour there are few transactions 0/unconfirmed, in memory pool. It is like every fourth transaction is not finished and pending.

image

And private balance still pending:

image
justanwar commented 1 year ago

@nrsimha Your issue is the same as #1297 (which was opened by you). My issue is the lack of IS-lock, which is indicated by the lack of key icon in transaction list. You can try it out by doing a transparent-to-transparent transaction and see if it is locked.

levonpetrosyan93 commented 1 year ago

Fixed in commit 39510e31b4d45bdb058440ad110b134e197ebb27