search

firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Adress / Label in Transactions view is not showed for Spark transactions #1299

Closed nrsimha closed 1 year ago

nrsimha commented 1 year ago

Describe the issue

When sending with Spark there is no address (or label) to which Firo has been sent to. Column for Address / Label shows '(n/a)'. I would expect there will be either label of address I sent transaction to or address (in case label is not defined).

image

Local setup

OS: Macos Ventura 13.4.1 (22F82) Firo QT: Firo Core version v0.14.12.4-g0f292f6f0 (64-bit)

Any extra information that might be useful in the debugging process.

Proper label shows only when receiving to transparent address.

To duplicate. Add Spark address with label. Send Firo to that address. Go to Transactions view and there is (n/a) as Address/ Label for that transaction.

By showing details of the transaction there is also not listed address to which was it send:

image
justanwar commented 1 year ago

Please reply to this post with a mainnet Firo address for the bug bounty payout. Use a new address that has never been used before. Make sure to anonymize after receiving!

nrsimha commented 1 year ago

aNGP5hUXBNsp1PVNXwNwf4rvAsfiu2KDM6

justanwar commented 1 year ago

TXID: 46fdf2303c332963d821c1b200631bc313694d5f7a9542853d7d24384142ff67

justanwar commented 1 year ago

Fixed in https://github.com/TheArcadiaGroup/firo_spark/commit/c85236da0e08bdeb915b92506773f17ea199559f