firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Remove memo padding during coin identification #1380

Closed AaronFeickert closed 11 months ago

AaronFeickert commented 11 months ago

Spark transactions include an encrypted memo. To reduce metadata, the memo is padded to a fixed length before encryption. This is somewhat subpar, as the padding is not removed.

A straightforward way to improve the user experience and avoid confusion would be to prepend the memo length before padding, and include this length in the encrypted data.