firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Add a warning about AEAD use #1382

Closed AaronFeickert closed 11 months ago

AaronFeickert commented 11 months ago

PR intention

Adds a warning to Spark AEAD code.

Code changes brief

Spark uses an AEAD for encrypting recipient data. For this purpose, it's safe and efficient to use a fixed zero nonce. However, this is not safe for broader use.

This PR adds a scary warning.