search

firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Update binding hash function signature #1396

Closed AaronFeickert closed 10 months ago

AaronFeickert commented 10 months ago

PR intention

Updates SpendTransaction::hash_bind_inner to make it static and take S1 and T as arguments.

Code changes brief

Previously, the function in question was not static, and inferred S1 and T from the object. This was inconsistent and had a bad code smell.

This PR makes the function static and is explicit about all fields used in the hash.

AaronFeickert commented 10 months ago

This shouldn't affect verification, but should be tested with a reindex to confirm.