search

firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Multi send #1445

Open levoncrypto opened 5 months ago

levoncrypto commented 5 months ago

This update enhances multi-sending capabilities. Previously, sending from a transparent address was limited to either another transparent address or a private address. Now, you can send Firo from a transparent address to a private and transparent address. Transaction fees will be evenly distributed across all transactions. When the fee is intended to be deducted from the sent amount, it will be deducted from the total transaction, not from any specific transaction. Sending Firo has now become more versatile and functional.

coderabbitai[bot] commented 5 months ago

Walkthrough

The changes primarily focus on enhancing the functionality and validation of Spark transactions, including minting, sending, and spending Spark tokens. The updates introduce new parameters, improve transaction handling, and refine the logic for validating and processing transactions. Additionally, modifications in the UI components reflect these backend changes, ensuring seamless integration and user experience.

Changes

Files/Groups Change Summaries
qa/rpc-tests/llmq-is-spark.py Added loop for multiple transactions, validation for transaction values, and instant lock checks.
qa/rpc-tests/spark_mint.py Expanded minting amounts, updated address handling, and adjusted verification logic.
qa/rpc-tests/spark_setmintstatus_validation.py Renamed variables and added new minting logic with additional address parameters.
qa/rpc-tests/spark_spend_gettransaction.py Updated variable names and added logic for minting and spending Spark tokens.
src/qt/sendcoinsdialog.cpp Modified conditions related to transaction preparation based on fAnonymousMode and sparkAddressCount.
src/qt/sparkmodel.cpp Added include for wallet header and refactored MintAndStoreSpark function call.
src/qt/walletmodel.cpp Added new vector for recipients and refactored address validation and data handling logic.
src/qt/walletmodeltransaction.cpp Changed iteration from recipients to transaction outputs in reassignAmounts function.
src/spark/sparkwallet.cpp Enhanced transaction amount handling and output adjustments in CreateSparkMintTransactions.
src/spark/sparkwallet.h Added parameter to CreateSparkMintTransactions function.
src/test/evospork_tests.cpp Modified MintAndStoreSpark function call to include vecSend parameter.
src/test/fixtures.cpp Introduced new vector for recipients in GenerateMints method.
src/wallet/rpcwallet.cpp Enhanced mintspark function to support various address types and parameters.
src/wallet/test/spark_tests.cpp Updated MintAndStoreSpark calls in test cases to include vecSend parameter.
src/wallet/wallet.cpp Added logic related to vecSend and subtractFeeFromAmount in MintAndStoreSpark and CreateSparkMintTransactions.
src/wallet/wallet.h Updated CreateSparkMintTransactions and MintAndStoreSpark function signatures to include vecSend.

Poem

In the realm of Spark, where tokens gleam,
We've added loops and checks supreme.
With minting magic, values soar,
Transactions flow like never before.
From wallets deep to tests so bright,
Our code now shines with Spark's new light.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.