Closed psolstice closed 3 months ago
[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between cf19353555dea925fcadb4381f5ac5fa9c87cc47 and 0f7a908e569d64ca409a07cf2f4c4fb439145be5.Files selected for processing (5)
* src/qt/sendcoinsdialog.cpp (8 hunks) * src/qt/walletmodel.cpp (1 hunks) * src/qt/walletmodel.h (1 hunks) * src/wallet/coincontrol.h (2 hunks) * src/wallet/wallet.cpp (1 hunks)_____________________________________________________________________________ < Easy things should be easy and hard things should be possible. - Larry Wall > ----------------------------------------------------------------------------- \ \ \ \ /\ ( ) .( o ).
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
PR intention
By design it's impossible to spend from spark to exchange address directly. Therefore, the user must go through transparent address if he wants to do so. This PR automates this process in Qt client and creates two transactions: the first one spending spark to transparent address and the second one sending newly created funds to exchange address(es).
Code changes brief
Changed Qt code handling "Send" page to support this scenario. Some slight modifications to core coin control functionality to force spending without creating extra
vout
for change (privacy reasons).