Closed levonpetrosyan93 closed 5 months ago
Currently, Firo’s max transaction limit size is 100 kB (inherited from Bitcoin) though some people are hitting this limit especially when dealing with many masternode or mining payouts. The error that pops up is 'Transaction is too large". The limit is there to prevent DDoS and ensure transactions can propagate properly.
Core team proposed to up this to 250 kB to account for the larger size of Spark transactions and also since we already have a larger block size limit. This will assist with UTXO consolidations as well and UX.
While technically not a hard fork since nodes will accept into the block, the transaction will not be relayed where the transaction is greater than 100 kB so this would be a mandatory upgrade.
We sought community feedback and there were no objections: https://forum.firo.org/t/feedback-on-upping-transaction-limit-size-from-100-kb-to-250-kb/3196
Walkthrough
This update increases the maximum transaction weight from 520,000 to 1,000,000 in the relay and mining policy. Adjustments are made across multiple files to reflect this new limit, ensuring consistent application in transaction validation and creation processes.
Changes
MAX_NEW_TX_WEIGHT
constant from 520000 to 1000000.MAX_NEW_TX_WEIGHT
instead ofMAX_STANDARD_TX_WEIGHT
.CWallet::CreateTransaction
method to compare transaction weight againstMAX_NEW_TX_WEIGHT
.Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Tips
### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit