search

firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
720 stars 354 forks source link

Update macOS Build Instructions for Dependency and Configuration IssuesMac os build fix #1462

Closed firstcryptoman closed 5 months ago

firstcryptoman commented 5 months ago

Description

This pull request revises the macOS build instructions for the Firo wallet, addressing dependency recognition and configuration issues on macOS Sonoma 14.5 with an M chip Mac.

Key Changes Include:

  1. Boost Library Configuration:

    • Adjusted the build instructions to ensure proper recognition of the Boost libraries, which were not initially recognized. This includes specifying the correct paths for the Boost headers and libraries in the configuration settings.

  2. Dependency Installation Adjustments:

    • Updated the instructions to include m4 and python-setuptools in the Homebrew installation commands, addressing issues where these tools were not recognized post-installation. This ensures a more streamlined setup and reduces configuration errors during the build process.

  3. Environment Setup:

    • Outlined the necessary steps for setting up the development environment on macOS, with considerations for the specific challenges posed by the latest macOS versions and hardware configurations.

Purpose:

The updates aim to streamline the setup process for developers on macOS, ensuring all key dependencies like Boost, m4, and python-setuptools are installed and recognized correctly, enhancing the clarity and accuracy of the build instructions.

Testing:

These revised instructions have been tested on macOS Sonoma 14.5 with an M chip Mac.

coderabbitai[bot] commented 5 months ago

Walkthrough

The update introduces enhanced build instructions for macOS, improved UI resizing functionality, and clearer error messages across various classes. Most significant is the addition of resizeEvent methods to dynamically adjust component sizes based on window dimensions and informative errors for transaction size limits.

Changes

File(s) Change Summary
doc/build-macos.md Reorganized build instructions for macOS, clarified steps, and added instructions for building and running unit tests.
src/qt/bitcoingui.cpp, src/qt/bitcoingui.h Refined toolbar and logoLabel declarations; added resizeEvent method for dynamic resizing.
src/qt/masternodelist.cpp, src/qt/masternodelist.h Added methods resizeEvent and adjustTextSize for dynamic component resizing and text size adjustment.
src/qt/overviewpage.cpp, src/qt/overviewpage.h Introduced resizeEvent and adjustTextSize methods to handle resizing events and adjust widget dimensions.
src/qt/receivecoinsdialog.cpp, src/qt/receivecoinsdialog.h Added resizeEvent and adjustTextSize methods for dynamic UI adjustments.
src/qt/sendcoinsdialog.cpp, src/qt/sendcoinsdialog.h Implemented methods to handle resize events and adjust text sizes dynamically.
src/qt/sendcoinsentry.cpp, src/qt/sendcoinsentry.h Introduced resizeEvent and adjustTextSize methods for dynamic resizing.
src/qt/transactionview.cpp, src/qt/transactionview.h Added resizeEvent and adjustTextSize methods for adjusting component sizes based on resize events.
src/rpc/misc.cpp, src/rpc/server.cpp, src/rpc/server.h Added checkifmncollateral function and RPC command for masternode collateral checks.
src/spark/sparkwallet.cpp, src/wallet/lelantusjoinsplitbuilder.cpp, src/wallet/txbuilder.cpp, src/wallet/wallet.cpp Updated error messages for better guidance on transaction size limits.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GUI
    participant Wallet
    User->>+GUI: Initiate Transaction
    GUI->>+Wallet: Create Transaction
    Wallet-->>GUI: Transaction too large (size limit: 100Kb). Select less inputs or consolidate your UTXOs
    GUI-->>User: Display Error Message

Poem

In fields where code and bytes do leap,
A rabbit sang with heart so deep.
"Resize your windows, let them play,
Adjust text size without delay!
Errors clear as morning dew,
Build on Mac, just follow through."
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
firstcryptoman commented 5 months ago

Closing this PR due to integration conflicts with recent updates in the master branch; I will resolve these and reopen a new PR as needed.