firoorg / firo

The privacy-focused cryptocurrency
https://firo.org
MIT License
721 stars 357 forks source link

Fix warnings in build process #1470

Closed psolstice closed 1 month ago

psolstice commented 2 months ago

Supersedes #1423

Update lib immer to a more recent version (v0.8.1 5875f7739a6c642ad58cbedadb509c86d4212). This fixes a lot of random warnings we have in lib immer. Fixed warnings in Linux / Clang. Fixed warnings in Win cross-compile.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes encompass extensive updates to the immer library, including reorganization and addition of headers, enhancements to algorithm functionalities, and improved exception handling. Key modifications include new utilities for data structures, adjustments to macros and configurations, and updates to array and node components. These changes improve readability, maintainability, and the overall robustness of the library.

Changes

Files/Paths Change Summaries
src/Makefile.am Reorganized and updated immer headers, changes in immer directory structure.
src/compat/glibcxx_sanity.cpp Suppressed unused return value warning in sanity_test_range_fmt.
src/immer/algorithm.hpp Added includes, refactored accumulate function, introduced differ and diff functionalities.
src/immer/{array.hpp,array_transient.hpp} Added IMMER_NODISCARD, new member functions, and reordered includes.
src/immer/atom.hpp Renamed types and variables, adjustments to move constructors and method signatures.
src/immer/box.hpp Added #include <cstddef>, reformatted constructors, added comparison operators.
src/immer/config.hpp Introduced macros for C++17 features, exception handling, debugging options, and optimizations.
src/immer/detail/arrays/{no_capacity.hpp, node.hpp} Added includes, refactored methods, improved exception handling, and assertions.
src/immer/detail/arrays/with_capacity.hpp Added includes, refactored constructor and destructor, added data_mut method.
src/immer/detail/combine_standard_layout.hpp Added includes, refactored struct definitions, improved formatting and conditional logic.
src/immer/detail/hamts/{bits.hpp, champ_iterator.hpp} Added includes, refactored functions and type definitions, added assertions, modified end_ calculation.

Poem

Amidst the code, where changes brew,
New headers dawn, old ones bid adieu.
Arrays and atoms, they transform with grace,
Refactored lines, in a seamless embrace.
🎉 To algorithms that now differ and shine,
Here's to progress, in every define! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
justanwar commented 2 months ago

Except for EXCEPTION_ACCESS_VIOLATION when starting Qt wallet with -disablewallet flag (not that you should), everything looking good so far.