firoorg / ztm

A REST service running on top of Zcoin Exodus to provides rich and easy to use APIs for managing the token
https://ztm.readthedocs.io
MIT License
4 stars 3 forks source link

Change uint256 format to big endian #174

Closed thebevrishot closed 4 years ago

thebevrishot commented 4 years ago

closes https://github.com/zcoinofficial/ztm/issues/172

codecov[bot] commented 4 years ago

Codecov Report

Merging #174 into master will increase coverage by 1.97%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #174      +/-   ##
=========================================
+ Coverage   87.73%   89.7%   +1.97%     
=========================================
  Files         133     148      +15     
  Lines        4507    5274     +767     
=========================================
+ Hits         3954    4731     +777     
  Misses        516     516              
+ Partials       37      27      -10
Impacted Files Coverage Δ
...tity.Postgres/DbContextOptionsBuilderExtensions.cs 100% <100%> (ø)
src/Ztm.Data.Entity.Postgres/ByteaHandler.cs 100% <100%> (+100%) :arrow_up:
...rc/Ztm.Data.Entity.Postgres/MainDatabaseFactory.cs 100% <100%> (+100%) :arrow_up:
src/Ztm.WebApi/Controllers/ErrorController.cs 0% <0%> (ø) :arrow_up:
src/Ztm.Configuration/ConfigurationExtensions.cs 100% <0%> (ø) :arrow_up:
src/Ztm.Data.Entity/Contexts/MainDatabase.cs 100% <0%> (ø) :arrow_up:
src/Ztm.WebApi/Startup.cs 0% <0%> (ø) :arrow_up:
src/Ztm.Testing/TestAddress.cs 100% <0%> (ø) :arrow_up:
src/Ztm.WebApi/ControllerBaseExtensions.cs 100% <0%> (ø) :arrow_up:
src/Ztm.Zcoin.NBitcoin/Exodus/SimpleSendEncoder.cs 100% <0%> (ø) :arrow_up:
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b02e56...a1730c2. Read the comment docs.

thebevrishot commented 4 years ago

After personal discussion, We can merge it without data migration script if we can finish this before first release.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 889924db6ed3fd92a3ed873f9529d28d7cf3dd78 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 8cfbf443e0c082d1b3a44cd02d2580f9bfc11bd0 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 62cb22e4191387aba69ac00656242332b706be59 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 55a919af14fcc1de05fd0b341dc2566f15d862c4 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging 9cebc7eaf38e19989cb1b0af97856bcd4d1697e5 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging aeeefc9696e6aaba6d4a2809cfabf4991fde9f9f into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 3e5043655924aaa7b948bbf4c8f72b098770c827 into a135d05bb2fc9c0f30b8475731270c08511fc88e - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 3c9929a4d4203f387214de0ccc0bd32b14fa401a into 0ae0565e94c34e9aa4ab5a5aed618a31b1e2e6fc - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging bc483b9a0f5e7ab2bed598354881d332eee427cc into 0ae0565e94c34e9aa4ab5a5aed618a31b1e2e6fc - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging a1730c2cac880757bd122a7295aacffae592e1bb into 0ae0565e94c34e9aa4ab5a5aed618a31b1e2e6fc - view on LGTM.com

new alerts: