search

first95 / FRC2020

Code base for 2020 robot, initialized with develop branch of 2019 repo.
MIT License
1 stars 1 forks source link

Would be nice to have a way for the elevator "go to setpoint" command to exit into hold-position mode #2

Closed jwalthour closed 4 years ago

jwalthour commented 5 years ago

Right now, after completing automated ground loading of a hatch, the elevator drifts downward. That's because in the cancel() function, stopElevator() is called. This causes the elevator to stop holding position.

This was originally done as a fail-safe. We probably want to either a) replace the cancel with a command to hold position, or b) give the command a way to have two difference cancellation behavior.

NHDinosaur commented 4 years ago

Since we're not sure if we're gonna have an elevator for next year, we should keep this enhancement issue open.

lindsayvallen commented 4 years ago

That's fine, but I'm going to icebox it until we know if we'll have an elevator.

lindsayvallen commented 4 years ago

We're not going to have an elevator so I'm closing this issue.