search

firstBitSportivnaya / PSSL

Проектная библиотека подсистем
Apache License 2.0
63 stars 7 forks source link

Parameters and variables in custom func #67

Closed denisushakov closed 6 months ago

denisushakov commented 6 months ago

Changed substitution of parameters and variables in the code console. Changed forms.

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent changes across various files aim to refine user interactions, optimize logic, and introduce new features within the 1C:Enterprise platform. These updates encompass UI enhancements, event handling improvements, command structure modifications, and parameter management enhancements to streamline operations and enhance user experience.

Changes

File Path Change Summary
.../__ПользовательскиеФункции/Forms/УсловныйОператор/Ext/Form.xml
.../__ПользовательскиеФункции/Forms/ФормаЭлемента/Ext/Form/Module.bsl		 UI enhancements, new command locations, buttons, event handling updates, and logic improvements.
.../CommonForms/__ФормаВыбораПоля/Ext/Form.xml UI redesign, command set updates, and attribute modifications.
.../CommonModules/__ОбщегоНазначенияСервер/Ext/Module.bsl Function updates for parameter handling and string manipulation.
.../__СтандартныеПодсистемыКлиент.xml
.../__СтандартныеПодсистемыСлужебныйКлиент.xml
.../__СтандартныеПодсистемыКлиент/Ext/Module.bsl
.../__СтандартныеПодсистемыСлужебныйКлиент/Ext/Module.bsl		 Metadata and library enhancements for subsystem management and module expansion.
Configuration.xml Addition of new common modules for client and service client subsystems.

Poem

"In the code's dance, changes play, 🐇💻
Buttons bloom, forms find their way.
Logic twists, UIs gleam,
A tech symphony, like a dream.
With each tweak, a tale we sow,
In bits and bytes, our system's glow."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonar-openbsl-ru-qa-bot[bot] commented 6 months ago

Passed

Analysis Details

20 Issues

Coverage and Duplications

Project ID: PSSL

View in SonarQube

sonar-openbsl-ru-qa-bot[bot] commented 6 months ago

Passed

Analysis Details

17 Issues

Coverage and Duplications

Project ID: PSSL

View in SonarQube

ivanmolodec commented 6 months ago

При выборе в параметрах типа ТаблицаЗначений выпадает ошибка:

Тип не определен (ТаблицаЗначений)
{Справочник.__ПользовательскиеФункции.Форма.ФормаЭлемента.Форма(257)}:ПустаяКоллекция = Новый(Тип(ВыбранныйЭлемент.Значение));
sonar-openbsl-ru-qa-bot[bot] commented 6 months ago

Passed

Analysis Details

17 Issues

Coverage and Duplications

Project ID: PSSL

View in SonarQube

ivanmolodec commented 6 months ago

Есть ещё один нюанс. На форме есть реквизит "Контекст" и при его смене заполняются параметры (это нужно для того чтобы можно было добавлять предопределенные контексты с набором заранее прописанных параметров) и при этом не присваивается гуид ну и дальше всё работать начинает некорректно. Было бы неплохо доработать чтобы при смене контекста параметрам тоже проставлялся гуид ну и чтобы можно было тип параметров прописать предустанавливаемых тоже

sonar-openbsl-ru-qa-bot[bot] commented 6 months ago

Passed

Analysis Details

20 Issues

Coverage and Duplications

Project ID: PSSL

View in SonarQube

sonar-openbsl-ru-qa-bot[bot] commented 6 months ago

Passed

Analysis Details

17 Issues

Coverage and Duplications

Project ID: PSSL

View in SonarQube