firstandthird / load-grunt-config

Grunt plugin that lets you break up your Gruntfile config by task

firstandthird.github.io/load-grunt-config/

MIT License

374 stars 64 forks source link

Support function tasks with description #73

Closed htanjo closed 10 years ago

htanjo commented 10 years ago

Related to #66, Includes #72 code. This PR supports function tasks with description using aliases.js.

72 fixes the error in this case:

// aliases.js
module.exports = {
  myAlias: function (target) {
    // Function tasks here...
  }
};

And also this adds supporting below:

// aliases.js
module.exports = {
  myAlias: {
    description: 'Description of myAlias.',
    tasks: function (target) {
      // Function tasks here...
    }
  }
};

I think these function tasks are useful. Thank you!

pigulla commented 10 years ago

This is needed, please merge.

jgallen23 commented 10 years ago

thanks. can you add tests?

htanjo commented 10 years ago

Hi, I added tests and merged with 0.12.0. I added a new config file "fixtures/testconfig.js" for the following reason.

"fixtures/output.js" is used in other tests and follows aliases.yaml. We can't define a function task in yaml file.
Even if we replace the yaml with aliases.js, "gruntConfig" test will fail because deepEqual assertion doesn't work with object contains functions.

I'm not sure if it satisfies you... Please let me know if you have any idea.

jgallen23 commented 10 years ago

took #80 instead. Make sure this fixes your use case too. released as 0.13.1