Doesn't draw properly to shadow-canvas on mobile when elements are added above the canvas

firstandthird / scribble

Javascript library for turning an element into a canvas for drawing

MIT License

2 stars 3 forks source link

Doesn't draw properly to shadow-canvas on mobile when elements are added above the canvas #6

Open willthefirst opened 10 years ago

willthefirst commented 10 years ago

To replicate:

use mobile phone, chrome with touch-event emulation, or the ios simulator to view your example/index.html file.
add an <h1>some text here</h1> above the canvas in example/index.html, and observe that the line will start drawing at a lower position equal to the offset that the h1 imposes, and slightly to the right. it also traces a line form the actual starting point to this false offset starting point.

willthefirst commented 10 years ago

did you guys solve this? thought you might like to see your plugin in production:

http://www.theworldsbiggestgameoftelephoneever.com/

would love to continue improving our game using your plugin, and have a bunch ideas concerning bugs and improvements. let me know if you are interested.

Antonio-Laguna commented 10 years ago

Hi Will,

It seems I missed this issue, apologies for that.

We are interested indeed. I haven't tried with that exact issue you're describing but I've certainly tried to place the scribble on some other structures that aren't simple like the one on the demo. I'll try and see what could be going on. Have you tried recently?

We updated scribble like a month ago with some other code.

willthefirst commented 10 years ago

Cool! I'll have a look at integrating it back into our project. Here's the commit I made when trying to fix the error a while back, seemed to do the trick, although I've now heard back from users that it's coming up again:

https://github.com/7imon7ays/web-telephone/commit/8bc5768e5dcf7d211531d94bddefc7eaaf6774d9

On Tue, Apr 29, 2014 at 10:51 AM, Antonio Laguna notifications@github.comwrote:

Hi Will,

It seems I missed this issue, apologies for that.

We are interested indeed. I haven't tried with that exact issue you're describing but I've certainly tried to place the scribble on some other structures that aren't simple like the one on the demo. I'll try and see what could be going on. Have you tried recently?

We updated scribble like a month ago with some other code.

Reply to this email directly or view it on GitHubhttps://github.com/firstandthird/scribble/issues/6#issuecomment-41685516 .

Will

willthefirst commented 10 years ago

Hey fellas, our website that uses your plugin (http://www.theworldsbiggestgameoftelephoneever.com) has garnered 100,000 submissions in a week, so you should probably be interested in this. We've got a bunch of improvements that we're thinking about, and just wanted to see whether you would like to discuss a potential collaboration.

This may conversation may be better had over email, you can hit me up at willthefirst@gmail.com

jgallen23 commented 10 years ago

wow. that's awesome! I'm a little swamped right now, but I'll hit you up sometime this week

willthefirst commented 10 years ago

Sounds good Greg.

On Mon, May 5, 2014 at 2:07 PM, Greg Allen notifications@github.com wrote:

wow. that's awesome! I'm a little swamped right now, but I'll hit you up sometime this week

Reply to this email directly or view it on GitHubhttps://github.com/firstandthird/scribble/issues/6#issuecomment-42218085 .

Will