Refactor for version 1.0

firstandthird / weekly

a jQuery Weekly Calendar Plugin

MIT License

3 stars 2 forks source link

Refactor for version 1.0 #39

Open jgallen23 opened 9 years ago

jgallen23 commented 9 years ago

Currently we do a lot of date manipulation ourselves. I think we can simplify the library quite a bit by swapping all the date logic with moment. We should also remove all of the timezone stuff and use moment timezone instead. We could also look into separating out the rendering from the logic, that way the angular plugin could use the native angular template rendering. Maybe have a weekly-base repo that handles the logic and puts a big json object together for the views to render. Just a thought.

@Belelros would be great for you to take a deep dive and look how we can make the library a little more modular and clean it up.

jgallen23 commented 9 years ago

@Belelros how is this going?

Antonio-Laguna commented 9 years ago

Getting started. Created a branch already and will push there periodically

Antonio-Laguna commented 9 years ago

Let me know when you're around and have time to chat and let's have a quick catch up on this. Just want to make sure I make sensible changes.

jgallen23 commented 9 years ago

let me know when this is ready to review

jgallen23 commented 9 years ago

can you explain the main things you changed? I see swapping out stuff for moment, but there still seems to be a tight couple between the logic and the template. It would also be nice to incorporate mobile into the main lib so you can just pass in a different template for mobile and the backend is the same

Antonio-Laguna commented 9 years ago

Sure, this is what I did (or thought I did)

Removed all logic from template. Not sure what are you seeing between the logic and the template. What I can see now is that there are no functions being called from the template (no format and no canAdd). I tried to make it in a way that was "Angular like"
Removed TZ logic to replace it by Moment.
Removed every Date object creation in favour of Moment since it's easier to work with. Sticking to dates when it's to save things.
Normalised some vars in the template (hiding button ones)
Removed from date helper most of the methods.

The mobile step was the next one I wanted to make. Just wanted to see if this was "enough" or if you wanted to do something else.