search

firstbatchxyz / dkn-compute-node

Compute Node of Dria Knowledge Network.
Apache License 2.0
88 stars 34 forks source link

bug: Cancellation for Workflows #72

Closed erhant closed 3 months ago

erhant commented 4 months ago

Outer wait-for-termination does not work when we are within that select!.

andthattoo commented 3 months ago

is this for @caglacelik ?

erhant commented 3 months ago

yea I think she can look into it, there is a cancellation check at https://github.com/firstbatchxyz/dkn-compute-node/blob/master/src/handlers/workflow.rs#L57 but it doesnt seem to work

maybe we can also think of adding cancelation to ollama workflows as well?