search

firstcontributions / firstcontributions.github.io

Web app for First Contributions
https://firstcontributions.github.io
MIT License
359 stars 405 forks source link

Fix width (and maybe height) of cards #15

Closed CarlosUvaSilva closed 4 years ago

CarlosUvaSilva commented 5 years ago

Cards are not full width in some cases and heigth is different depending on number of tags or description length. 🐞 Problem Full width for all cards and maybe fixed height. Need to test this last enhancement. 🎯 Goal Looks nicer when all the cards have same size

CarlosUvaSilva commented 5 years ago

I'm working on this one for Hacktober Fest

CarlosUvaSilva commented 5 years ago

Can you give me permissions to write to a new branch? Would like to create a PR

Roshanjossey commented 5 years ago

@CarlosUvaSilva, fork this project, create a branch there. Push to it and submit a pull request.

Read this to learn more about it https://github.com/firstcontributions/first-contributions/blob/master/README.md

Also I didn't quite understand what you're trying to achieve. Could you please share screenshots/ proposed design?

CarlosUvaSilva commented 5 years ago

I'm not at home atm, I'll submit the PR when I get there. what I'm trying to fix is the difference in width inside the card. I believe this is due to the fact that the image's width is different between cards

screen shot 2018-10-03 at 14 12 23

Roshanjossey commented 5 years ago

@CarlosUvaSilva, got it. I hadn't checked this is smaller screens.

Please take your time. No need to hurry.

sara-02 commented 5 years ago

@Rohit777 @CarlosUvaSilva is this issue fixed?

Roshanjossey commented 4 years ago

@sara-02 , this is fixed. Closing