firstdarkdev / modpublisher

A dual publishing Gradle Plugin to publish mods to Modrinth, Curseforge and GitHub in one go
MIT License
17 stars 3 forks source link

Issue(?): Modrinth upload debug output does not list files. #23

Open iChun opened 2 weeks ago

iChun commented 2 weeks ago

Doing a debug upload to Modrinth doesn't list the files uploaded unlike its CurseForge counterpart

Output:

Scanning <JARFILE> for presence of fractureiser
Full data to be sent for upload: {
  "name": "[1.20.6 NeoForge] v 1.0.0",
  "versionNumber": "1.0.0",
  "changelog": <STRIPPED>,
  "dependencies": [],
  "gameVersions": [
    "1.20.6"
  ],
  "versionType": "release",
  "loaders": [
    "neoforge"
  ],
  "featured": false,
  "projectId": <STRIPPED>
}

I wasn't sure if this was intentional or not, I was testing the new addAdditionalFiles from https://github.com/firstdarkdev/modpublisher/issues/5#issuecomment-1904499313 and wanted to test that the additional files are still uploaded to Modrinth as the documentation isn't clear on this (it says it's only supported on CF). I've seen from the code that it is, but wanted to double check.

hypherionmc commented 2 weeks ago

I don't even remember adding the additional files to modrinth 😅

I actually saw this as well. What's strange, is we use the same method as Minotaur (modrinths plugin) to print the debug output, so it is very strange that the files are not included.

project.getLogger().lifecycle("Full data to be sent for upload: {}", gson.toJson(builder.build()));

Will have to see if I missed something somewhere.

Side Note: I see my comment on the addAdditionalFiles is misleading. The changelog and display name override is only supported on CurseForge (as far as I know, modrinth doesn't support this).

iChun commented 2 weeks ago

It could be entirely possible that Minotaur also doesn't print out the files on debug, have not used them before.

Thanks for looking into this though!