firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Add Dockerfile for Gitpod #109

Closed jelaniwoods closed 4 years ago

jelaniwoods commented 4 years ago

By using a Dockerfile in each project, we can pre-bundle the gems for each project. We also aren't installing multiple versions of gems in the image that was causing some issues with firstdraft/appdev#216.

The requested changes are:

The one hangup:

You can open this branch of photogram-signin in Gitpod to see the changes. Open in Gitpod

pmckernin commented 4 years ago

Thank you for explaining this to me at Harper, makes sense and LGTM

jelaniwoods commented 4 years ago

Closing in favor of #130