Closed jelaniwoods closed 4 years ago
Webpacker and Rails 6 has a lot of extra stuff that increases load time, that students won't need for the basic projects.
This changes in this branch:
--skip-action-mailer --skip-javascript --skip-webpack-install
sass-rails
sassc-rails
sprockets
gem 'execjs'
therubyracer
action_mailer
development.rb
javascript_pack_tag
javascript_include_tag
application.html.erb
app/assets/javascripts/application.js
Clone, checkout jw-remove-webpacker branch,
rails new no-webpack --rc=<path to fd> -m <path to template.rb>
The new app should be able to navigate to:
/
/git
/admin
admin@example.com
password
There are a couple temporary changes I've made so that review is as easy as possible. In template.rb
template.rb
# ENV = :prod ENV = :dev
This change is because we're in development and the changes aren't in master yet.
master
In fd The removal of
fd
--template=https://raw.githubusercontent.com/firstdraft/appdev_template/master/template.rb
For similar reasons. I will add them back after approval.
fd is just an arbitraly named file that is used to store all the flags we run with rails new.
rails new
You can run rails to see the info:
rails
[--rc=RC] # Path to file containing extra configuration options for rails command
@jelaniwoods Excellent. I came to remind you not to forget to switch pack_tag for include_tag but looks like you are all over it. LGTM
pack_tag
include_tag
Webpacker and Rails 6 has a lot of extra stuff that increases load time, that students won't need for the basic projects.
This changes in this branch:
sass-rails
, replaced withsassc-rails
sprockets
less than version 4gem 'execjs'
andtherubyracer
for Gitpodaction_mailer
fromdevelopment.rb
javascript_pack_tag
withjavascript_include_tag
inapplication.html.erb
app/assets/javascripts/application.js
Clone, checkout jw-remove-webpacker branch,
The new app should be able to navigate to:
/
and see "Yay, you're on Rails/git
/admin
and login withadmin@example.com
andpassword
Note:
There are a couple temporary changes I've made so that review is as easy as possible. In
template.rb
This change is because we're in development and the changes aren't in
master
yet.In
fd
The removal ofFor similar reasons. I will add them back after approval.
Other Note
fd
is just an arbitraly named file that is used to store all the flags we run withrails new
.You can run
rails
to see the info: