search

firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

GitHub faker bundles too slowly on Heroku — lets use rubygems #117

Closed raghubetina closed 4 years ago

jelaniwoods commented 4 years ago

@raghubetina does it make sense to load github faker in development and rubygems faker in production? Or would Github still be loaded during the deploy?

raghubetina commented 4 years ago

@jelaniwoods I think I would rather have people run into a method missing error in while in development mode, and have to learn about the difference between loading the rubygems version versus the GitHub version if the need something bleeding edge and paying the price for it, than mysteriously have two different gems being loaded invisibly and then failing on production. Thoughts?

jelaniwoods commented 4 years ago

mysteriously have two different gems being loaded invisibly and then failing on production.

@raghubetina I didn't think about that. Having both version would most likely be more confusing. I agree with your proposal.

jelaniwoods commented 4 years ago

Done in https://github.com/appdev-projects/base-rails/blob/09e23e1326c82fc670bc375c026cb4875bdc7772/Gemfile#L17