firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Create views/application #133

Closed raghubetina closed 4 years ago

raghubetina commented 4 years ago

Since we start by teaching them to create actions directly within ApplicationController, thoughts on starting off our projects with a views/application folder so that they can create view templates directly without having to create a subfolder first?

We could even consider teaching them render("blah.html.erb") for simplicity instead of render("application/blah.html.erb") although that sacrifices some of the explicitness that I like. May not do that.

jelaniwoods commented 4 years ago

@raghubetina I believe this already happens here https://github.com/firstdraft/appdev_template/blob/master/template.rb#L235

jelaniwoods commented 4 years ago

@raghubetina from our conversation in slack, should application be renamed to something like app_templates?

See https://firstdraftchat.slack.com/archives/C0101C29XU4/p1589322308063600

raghubetina commented 4 years ago

@jelaniwoods Hmm, app/views/app_templates feels a bit redundant... and there's already so much "app" everywhere else already too (e.g. application.html.erb).

What do you think about

I sort of like the former because it sounds more "zebra"-ish — i.e., it sounds more arbitrary and less like a locked in part of the framework.

jelaniwoods commented 4 years ago

@raghubetina that's true. I think page_templates could be misleading. If we discourage students from using the ApplicationController and push them to create View folders that are named after a Controller— page_templates seems more in line with a PagesController (which we've used in projects before) than an ApplicationController. So I think maybe misc_templates would be better.

jelaniwoods commented 4 years ago

Closing due to inactivity.