firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Heroku Removing Gemfile.lock because it was generated on Windows #160

Closed raghubetina closed 4 years ago

raghubetina commented 4 years ago

I notice Heroku "Removing Gemfile.lock because it was generated on Windows". This caused an issue with the Google Translate gem; it stopped working after using a different version in production.

StackOverflow says:

https://stackoverflow.com/questions/20297205/heroku-removing-gemfile-lock-because-it-was-generated-on-windows

Since we and the students are all *nix, perhaps we can safely have appdev_template remove removex86-mingw32`? Thoughts?

jelaniwoods commented 4 years ago

I think it makes sense to remove it then. I assume it has to do with

gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
...
`bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`

There are a few other options listed here https://github.com/tzinfo/tzinfo-data/issues/12#issuecomment-279554001 are there any preferences on how to resolve?