Closed jelaniwoods closed 5 years ago
LGTM
@jelaniwoods Why both the file within /files
and the heredoc within template.rb
? Would one or the other suffice?
đź‘Ť
@raghubetina I made some changes since you last looked!
LGTM, although it makes me think the other file — fetch_store_patch.rb
I think it was? — should also be named after the module or class that it is monkey patching, for consistency. What do you think?
@raghubetina That makes sense. I didn't really arrive at a good naming convention when I was working on the patches, but I think that's a good idea.
From #37
Add an initializer called,
delegation_monkey_patch
to new projects and include the fix to use[ ]
on ActiveRecord Relations