Closed jelaniwoods closed 5 years ago
Based on your other PR, LGTM!
@jelaniwoods I guess while we're at it, for completeness, shall we also add store
as an alias for []=
?
@jelaniwoods In this case perhaps alias_method
is more suitable than alias
?
https://github.com/rubocop-hq/ruby-style-guide#user-content-alias-method
@raghubetina I trusted rubocop to handle it and got
Style/Alias: Use alias instead of alias_method in a module body.
thoughtbot has this style Enabled: false
, could that be why?
@jelaniwoods Ah interesting. Are we not using thoughtbot's .rubocop.yml
in this project? Usually that's the one we put in all projects.
@raghubetina I am using thoughtbot's .rubocop.yml
file. It looks like it doesn't have the style to use alias_method
over alias
enabled is what I mean.
@jelaniwoods Ah, that makes more sense. So now do we trust thoughtbot or bbatsov/BigBinary? I guess let's trust thoughtbot until we have a good reason not to.
@raghubetina I've added .store
to this pr too. How does this look?
@jelaniwoods LGTM :ship:
In response to this issue: #102
Alias the
:[]
attribute method forActiveRecord
with:fetch
.