firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Uncomment `bcrypt` gem from Gemfile #80

Closed jelaniwoods closed 5 years ago

jelaniwoods commented 5 years ago

Resolve #78

Uncomments the bcrypt gem from the Gemfile.

raghubetina commented 5 years ago

@jelaniwoods LGTM. I'm wondering if we should just have a Gemfile in the files/ folder and just swap it, rather than all these individual modifications. That would also allow us to re-order, format the file, etc. Thoughts?

jelaniwoods commented 5 years ago

@raghubetina That would make a lot of sense, considering all the Gemfile modifications we're making at this point. I guess the only other thing would be the one time gsub if we want the project to have devise or not. I think that would definitely clean up the code though.

raghubetina commented 5 years ago

@jelaniwoods Agreed. Sounds like a separate card, though. 🚢 on this one