firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Update to rails 6 #85

Closed jelaniwoods closed 5 years ago

jelaniwoods commented 5 years ago

Resolve #83

Update the template to configure Rails 6 apps in the decided way.

Clone, checkout jw-update-to-rails-6 branch,

rails new rails-6-test-app --rc=<path to fd> -m <path to template.rb> 

The new app should be able to navigate to:

Note:

There are a couple temporary changes I've made so that review is as easy as possible. In template.rb

# ENV = :prod
ENV = :dev

This change is because we're in development and the changes aren't in master yet.

In fd The removal of

--template=https://raw.githubusercontent.com/firstdraft/appdev_template/master/template.rb

For similar reasons. I will add them back after approval.

LoganDSPrice commented 5 years ago

I apparently don't have access to the firstdraft/web_get repo so it fails to create a new app using the template...

LoganDSPrice commented 5 years ago

OK yeah I thought that was weird. Looks like theres a typo in template.rb, ln. 55

jelaniwoods commented 5 years ago

@LoganDSPrice I've made the suggested changes. Could you take another quick look?

LoganDSPrice commented 5 years ago

I got the following error:

No such file or directory @ rb_sysopen - /Users/logandsprice/code/appdev/appdev_template/rails-6-test-app/app/assets/javascripts/application.js

There is, however, app/javascript/packs/application.js. Is it possible that despite skipping the webpack install, it's still placing the file where webpacker would expect it?

jelaniwoods commented 5 years ago

@LoganDSPrice that's my mistake! 😞 I made a typo in the description. The first flag should be --rc=<path to fd>. There was a different error that I fixed so you can pull to get those changes and try again.

LoganDSPrice commented 5 years ago

I was able to generate and run the server. Got "Yay! You're on rails!" LGTM :shipit: