Gitpod Updates - Githubissues

jelaniwoods commented 4 years ago

This branch addresses some issues we were having using gitpod. Occasionally, stale pid files were created preventing students from simply running bin/server and we had to rm the file for them.

Gitpod does a weird thing with changing ip addresses that prevented us from using the console_ip_whitelist gem. There also doesn't appear to be a way to whitelist all ips for BetterErrors.

To address these issues, I've made the following changes:

Make bin/server remvove any stale pid files if they exist
Whitelist All Gitpod ip addresses, BetterErrors::Middleware.allow_ip! '10.138.0.0/16'

I tested in this project, which you can fork or just open in Gitpod to test.

Fixes firstdraft/appdev#190 Fixes firstdraft/appdev#197

jelaniwoods commented 4 years ago

I intend to merge this today if there are no more comments. We've been using these changes in some of the GUI assignments as well as the signin assignments.

raghubetina commented 4 years ago

LGTM 👍

firstdraft / appdev_template

Gitpod Updates #90