firstdraft / appdev_template

A Rails template for generating homework projects
0 stars 1 forks source link

Audit Heroku pre-configuration #97

Closed raghubetina closed 4 years ago

raghubetina commented 4 years ago

Read through Heroku's Puma guide and make sure that appdev_template's puma.rb configuration, and generally Heroku configuration, is up to date for Rails 6.

https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server

If there are any changes, please also update our new app checklist.

jelaniwoods commented 4 years ago

@raghubetina the new app checklist says to add rack timeout, should that also be added to the template?

raghubetina commented 4 years ago

@jelaniwoods Hm. If so then we should increase the timeout to the Heroku max of 30 seconds, for students. The default of 15 is a good number for our own apps.

https://devcenter.heroku.com/articles/request-timeout

raghubetina commented 4 years ago

@jelaniwoods Does Heroku still recommend adding that gem in their guide?

jelaniwoods commented 4 years ago

@raghubetina Yes, the guide still suggests to add the Rack Timeout gem.

raghubetina commented 4 years ago

@jelaniwoods Okay, let's do in in appdev_template then, but let's increase the timeout to 30.