search

firstdraft / draft_generators

Rails generators that help beginners learn to program.
MIT License
2 stars 3 forks source link

removed div's from update and show #104

Open pmckernin opened 3 years ago

pmckernin commented 3 years ago

I have removed the extra div's leftover from bootstrap col in the index and show view.

I also changed the wording of the comment next to skip_before_action and force_signin to lead you to the other place.

This gitpod workspace has the generator branch changed and has already created an account and a resource.

Please feel free to create more resources and check to see if they work.

Open in Gitpod

raghubetina commented 3 years ago

Looks good. Made one suggestion.

Tiny nitpick for future: consider separating different tasks (e.g. the auth comments vs the divs) into different commits/PRs. This is to make it easier to review and also to make it easier to revert a commit later if e.g. a bug is discovered without losing other unrelated work.

Don't split this one up though; just keep it in the back of your mind.

jelaniwoods commented 3 years ago

@pmckernin Rewording the comments makes sense to make instructions more explicit for the students, but what was the motivation behind removing the divs?