search

firstdraft / draft_generators

Rails generators that help beginners learn to program.
MIT License
2 stars 3 forks source link

Added border=1 to draft resource. #109

Closed pmckernin closed 1 year ago

pmckernin commented 3 years ago

This branch resolves issue #100. The 'border="1"' was added to the draft resource generator.

Here is a snapshot of a workspace that has this branch specified.

Here is a photo of the old table vs the new table.

Screen Shot 2021-06-24 at 5 02 20 PM Screen Shot 2021-06-24 at 5 02 44 PM
pmckernin commented 3 years ago

@pmckernin I think the base branch is incorrect for this PR. We've currently been using winter-2020 branch for appdev.

Ok that makes more sense

jelaniwoods commented 3 years ago

@pmckernin you can edit the base branch of a PR after it's been created.

github-change-base-branch

in case you didn't know.

jelaniwoods commented 1 year ago

This has been implemented in https://github.com/firstdraft/draft_generators/commit/c51ea5f9f2a7d4d98de36984d40fc741e8993ad9