search

firstdraft / draft_generators

Rails generators that help beginners learn to program.
MIT License
2 stars 3 forks source link

Update parent name to support Rails 6.1+ #116

Closed jelaniwoods closed 2 years ago

jelaniwoods commented 2 years ago

Resolves #115

In Rails 6, this warning appears:

DEPRECATION WARNING: Module#parent_name has been renamed to module_parent_name. parent_name is deprecated and will be removed in Rails 6.1.

Now that AD2 (and soon AD1) projects are Rails 6.1+, we need to use module_parent_name instead. This PR updates the use of parent_name to module_parent_name.

I don't think backwards compatibility needs to be supported— since there are other branches/commits that past students have checked out. Perhaps this should be merged into master instead?

raghubetina commented 2 years ago

LGTM. Yes, I think we should rename master to main and use it going forward, rather than winter-2020.