search

firstdraft / draft_generators

Rails generators that help beginners learn to program.
MIT License
2 stars 3 forks source link

Remove "Rails Direct Uploads" from the navbar #62

Closed raghubetina closed 4 years ago

raghubetina commented 5 years ago

Right now rails g draft:layout is failing to ignore the /direct_uploads path when it detects what links to make in the navbar, since ActiveStorage is new. Make it ignore that.

pmckernin commented 5 years ago

I need some help on this, I looked through the navbar template files and am having trouble finding what I should be ignoring.

raghubetina commented 5 years ago

@pmckernin Which part of the code is run when the layout generator is used? Which part of that code deals with creating the links in the navbar? Have you been able to locate the relevant lines?

pmckernin commented 5 years ago

@raghubetina Yes, I believe the the following attached code is dealing with the creating of the navbar links. This is within the lib/generators/drafts/layouts/templates/_navbar.html.erb

Screen Shot 2019-08-19 at 3 24 04 PM
raghubetina commented 5 years ago

(GitHub tip: you can link to specific lines of code, which is better than screenshotting. There's a keyboard shortcut, y, to get the permanent link (which is locked to a specific commit).)

@pmckernin Yep that looks promising. What's the next step? Apparently app_resources has something in it that we don't want (Rails Direct Uploads).

jelaniwoods commented 4 years ago

@pmckernin I believe this is resolved now in this commit. Feel free to ask me about it if you want

jelaniwoods commented 4 years ago

@pmckernin we were talking a bit about templates and generators a couple days ago so it might be nice to talk about these changes if you had any questions.