Update draft:layout - Githubissues

firstdraft / draft_generators

Rails generators that help beginners learn to program.

MIT License

2 stars 3 forks source link

Closed jelaniwoods closed 4 years ago

jelaniwoods commented 4 years ago

At present it breaks due to javascript_include_tag changing to javascript_pack_tag nowadays.
Assets versions are outdated.
CDNs need to be updated.

The navbar resource links generator still haven't been updated:

This pr makes the updates specified in #61

raghubetina commented 4 years ago

Here's an issue:

Screen Shot 2019-11-21 at 11 47 08 AM

It should omit any POST, PATCH routes, perhaps? Or better yet, only allow GET.

jelaniwoods commented 4 years ago

@raghubetina I tried to exclude more routes from the navbar. It should be exclude non-GET routes now. I've also updated bootswatch cdn.

raghubetina commented 4 years ago

@jelaniwoods LGTM! :ship: