Winter 2020 updates - Githubissues

raghubetina commented 4 years ago

Goals:

Initially comment out the forcing of sign in code. Students can opt in to this behavior by un-commenting it if they want it. Thoughts?
Make the naming of routes more consistent between draft:resource and draft:account while still being appropriately descriptive of each.
Switch from match back to get and post.
Switch from the _from_path and _from_query suffixes of parameters to path_ and query_ prefixes; I believe this is a bit more clear because the former only makes sense when you're in the controller fetching, after the values have been placed into params. When you're initially labeling a flexible route or naming an input, it seems confusing why we're calling them e.g. "from query" when they're not in the query yet, they're in the form.

Perhaps we should instead consider naming these things _from_form (not strictly accurate if the query string was typed or e.g. API request) and from_uri. Is that better than query_ and path_?

jelaniwoods commented 4 years ago

@raghubetina I generated a resource and account to test and wrote some feedback here: https://github.com/jmw686-appdev/test-draft-account-gen/pull/2

raghubetina commented 4 years ago

@jelaniwoods Tyvm. I made some changes; can you take another look?

jelaniwoods commented 4 years ago

@raghubetina I generated another resource and account. The PR is here.

pmckernin commented 4 years ago

@raghubetina Everything looks good to me. I generated a User and another table and tested all routes and sessions for the user. Here is my workspace.

https://github.com/pmckernin/test_draft_resource

jelaniwoods commented 1 year ago

@raghubetina is it okay if I merge this into master?

raghubetina commented 1 year ago

Sure, thank you! Don't remember how this slipped through.

On Fri, Oct 21, 2022 at 12:19 PM Jelani Woods @.***> wrote:

@raghubetina https://github.com/raghubetina is it okay if I merge this into master?

— Reply to this email directly, view it on GitHub https://github.com/firstdraft/draft_generators/pull/75#issuecomment-1287238563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGGBUOQ5NWHJDRCG7CWXR3WELGDRANCNFSM4KW6JOMA . You are receiving this because you were mentioned.Message ID: @.***>

firstdraft / draft_generators

Winter 2020 updates #75