Remove Bootstrap from draft:resource

firstdraft / draft_generators

Rails generators that help beginners learn to program.

MIT License

2 stars 3 forks source link

Remove Bootstrap from draft:resource #85

Closed raghubetina closed 4 years ago

raghubetina commented 4 years ago

I propose that we remove Bootstrap from draft:resource to bring it in line with the G5 resources we've been building by hand.

Rationale:

The Bootstrap that is included is easy enough to add by hand, and seeing a page become pretty step by step by your own efforts is a nice win.
draft:layout is a pretty good head start by itself (includes assets, navbar) for people who want to Bootstrap.
Even though we don't require visual prettiness, seeing Bootstrap is an easy indicator of effort invested in a final project if we don't automate it.
Handwriting styles encourages more diverse styling. Otherwise they just stick with the components and layout that are generated.

Thoughts @jelaniwoods @pmckernin ?

pmckernin commented 4 years ago

@raghubetina I think this is a good idea.

jelaniwoods commented 4 years ago

I also think it's a good idea. I think we started having a discussion about this a quarter or two ago, but didn't have enough time to reach a consensus I think.

pmckernin commented 4 years ago

@raghubetina Do you also want to remove font awesome?

raghubetina commented 4 years ago

Yes, that seems like a good idea.

On Fri, Aug 7, 2020 at 1:59 PM pmckernin notifications@github.com wrote:

@raghubetina https://github.com/raghubetina Do you also want to remove font awesome?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/firstdraft/draft_generators/issues/85#issuecomment-670663145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGGBUKZA7H43O33YUJYDXTR7RFKZANCNFSM4PUFB72Q .

pmckernin commented 4 years ago

@raghubetina And just to be clear we want to remove all of the bootstrap classes from all of the views.

raghubetina commented 4 years ago

Everything in draft:resource, yes. Not the other generators, e.g. draft: layout.

On Fri, Aug 7, 2020 at 2:09 PM pmckernin notifications@github.com wrote:

@raghubetina https://github.com/raghubetina And just to be clear we want to remove all of the bootstrap classes from all of the views.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/firstdraft/draft_generators/issues/85#issuecomment-670668874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGGBUKRTNK6JIUDCHHD4H3R7RGNZANCNFSM4PUFB72Q .