search

firstfloorsoftware / flutter_sodium

Flutter bindings for libsodium
BSD 3-Clause "New" or "Revised" License
102 stars 46 forks source link

Update for swift 5 #15

Closed rmtmckenzie closed 5 years ago

rmtmckenzie commented 5 years ago

Unfortunately there's a bazillion warnings about

'withUnsafeMutableBytes' is deprecated: use withUnsafeMutableBytes<R>(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R instead

but I haven't figured out how to fix it. I opened a SO question and will do another PR once I do...

kozw commented 5 years ago

Once Dart FFI is available, we no longer need to worry about the native Swift (and Java) implementation. Don't invest too much time, flutter_sodium will get a major make-over. See also #12

rmtmckenzie commented 5 years ago

Fair enough, but it could be a while before that happens. I've done another PR (see #16) that does the changes to better swift 5 code.

rmtmckenzie commented 5 years ago

So that other PR is probably better, but I'll leave this in case there's any concerns about the code in the other one (I did use a lot of regex find/replace =D)