search

firstlookmedia / gpgsync

:lock: GPG Sync is designed to let users always have up-to-date public keys for other members of their organization
GNU General Public License v3.0
345 stars 27 forks source link

Ask Windows users to quit GPG Sync when upgrading #169

Closed huertanix closed 5 years ago

huertanix commented 5 years ago

OS: Windows 10 GPG Sync Version: 0.3.0 => 0.3.3

When attempting to install a newer version of GPG Sync (upgrading from 0.3.0 to 0.3.3), a cryptic error appears w/o any further instructions or option to do anything about it other than abort. This seems to be due to GPG Sync running, because it normally always is in the background, and needing to be quit. This error should ideally be handled with more user-friendly messaging (e.g. GPG Sync is currently running and needs to be [shut down|whatever the term for fully stopping a Windows program is] before upgrading.) and include an option to continue the install after the user has quit the running GPG Sync program.

gpg sync install error gpg sync install error message

micahflee commented 5 years ago

Good idea. This is in the installer, which is based on NSIS, specifically this file. It looks like the NSIS installer can be programmed to make sure GPG Sync is closed before proceeding with the installer using the NSProcess plugin: