firstpj
commented
1 year ago Thank you very much. I will try to fix that area.
On Thu, Apr 20, 2023 at 8:26 AM Sonika Kumar @.***> wrote:
Hi @Collins https://github.com/Collins, you have done a great job in replicating the figma design. Your Portfolio looks awesome!! 👍
I just found few things which you can fix, try considering them 😄
-
It would be good if you could name your class and ID's differently for more code readability in the line 👇 https://github.com/firstpj/Portfolio-Mobile-first-set-up/blob/907588a673ce552566910364c4ce40b45154655c/index.html#L17
In your Live link I found some spaces between the FIrst section and the second section you can maybe reduce them to match the figma template 👍
— Reply to this email directly, view it on GitHub https://github.com/firstpj/Portfolio-Mobile-first-set-up/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3MQM5TM3MVH3TNFTTNLJ7LXCDQK5ANCNFSM6AAAAAAXFCV7ZY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi @collins, you have done a great job in replicating the figma design. Your Portfolio looks awesome!! 👍
I just found few things which you can fix, try considering them 😄
It would be good if you could name your classes and ID's differently for more code readability in the line 👇 https://github.com/firstpj/Portfolio-Mobile-first-set-up/blob/907588a673ce552566910364c4ce40b45154655c/index.html#L17
In your Live link I found some spaces in between The First section and The Second section you can maybe reduce them to match the figma's template 👍