search

firstred / page-speed

Automatically exported from code.google.com/p/page-speed
0 stars 0 forks source link

MinimizeRedirects should only consider 301, 302, 303, and 307 as redirects #119

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The current redirect logic considers all 3xx codes to be redirects. At least 
301 and 302 are redirects, and probably others in the 3xx range should also 
be considered redirects. But at least 304 should not be considered a 
redirect.

Original issue reported on code.google.com by bmcqu...@google.com on 21 Sep 2009 at 1:51

GoogleCodeExporter commented 9 years ago 
r303 | avd@google.com | 2009-11-02 17:35:30 -0500 (Mon, 02 Nov 2009) | 5 lines

Do not treat 304s as redirects.
fixes: http://code.google.com/p/page-speed/issues/detail?id=119

r=mdsteele

Original comment by avd+personal@google.com on 2 Nov 2009 at 10:37

GoogleCodeExporter commented 9 years ago 
Thanks for the fix! 304 is the most critical case to treat as a non-redirect. 
However, 
the chrome impl considers 301, 302, 303, and 307 to be redirects. We should 
probably do 
the same. See

http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_headers.c
c?
view=markup

(search for IsRedirect)

Original comment by bmcqu...@google.com on 3 Nov 2009 at 12:22

GoogleCodeExporter commented 9 years ago 
marking low priority since 304 was the critical thing to fix.

Original comment by bmcqu...@google.com on 3 Nov 2009 at 12:44

GoogleCodeExporter commented 9 years ago

Original comment by bmcqu...@google.com on 3 Nov 2009 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by bmcqu...@google.com on 3 Nov 2009 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by mdste...@google.com on 25 Jan 2010 at 6:22