firstred / page-speed

Automatically exported from code.google.com/p/page-speed
0 stars 0 forks source link

Add enable/disable #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I think you should add enable/disable options,
the same as on tabs:
- Console
- Script
- Net

This will allow users to run your tool only on some pages, not all they have.

Very best,
Tomasz Kuter

PS. Great extension! It has many features I haven't seen before..

Original issue reported on code.google.com by Tomasz.K...@gmail.com on 6 Jul 2009 at 9:01

GoogleCodeExporter commented 9 years ago
Tomasz,
   Thanks for pointing this out.  

   Console, Script, and Net can be disabled because having them enabled forces
firefox to do extra work, slowing it down.  For example, the net panel saves
information about every network request.  I can't think of any work page speed 
does
unless you click "Analyze Performance" or "Record".  There is some cost to the
javascript coverage rule, but there is an option to disable this.  There is 
also some
overhead in code that stores network requests, but it is a global object shared 
among
all tabs, so we could only enable or disable it for every tab at once.

Bryan, 
  Can you think of anything else page speed does that has overhead?  If so, adding a
disable option might be worth it.  If not, than I am not sure what we could 
disable...

Sam

Sam

Original comment by sker...@google.com on 6 Jul 2009 at 3:44

GoogleCodeExporter commented 9 years ago
Hi Sam,
The very first think I though about your extension was:
"Oh, it's very similar to YSlow extension, made by Google's competitor: Yahoo."
But when I had looked a little closer I have seen some extra, absolutely new 
things ;-)

YSlow has option like "Analyse Performance": "Run test".
You can decide to "Autorun YSlow each time a web page is loaded"
It also hasn't such options like:
- Disable/Enable globally
- Disable/Enable for domain.com
But it could be much useful to have it.

Your extension is very similar in this way.
Analysing page structure and information takes some resources and time,
and I would like to have it enabled only on some domains, not all pages.
I mentioned about the option: "Autorun YSlow each time a web page is loaded" in 
your
competitor, because when you are working on some website you don't want to 
click on
"Analyse" button again and again ;-)

I hope you understand what I mean.

Very best,
Tomasz

Original comment by Tomasz.K...@gmail.com on 7 Jul 2009 at 12:15

GoogleCodeExporter commented 9 years ago

> YSlow has option like "Analyse Performance": "Run test".
> You can decide to "Autorun YSlow each time a web page is loaded"

Tomasz,
   Page Speed has the ability to run at onload as well.  There is a menu item named
'Automatically Run at Onload' in the options menu.  This is an example of state 
that
should be disabled if page speed is disabled, so I think your suggestion to 
allow
disabling page speed in the same way other firebug panels can be disabled makes
sense.  Issue accepted.

Sam

Original comment by sker...@google.com on 7 Jul 2009 at 8:07

GoogleCodeExporter commented 9 years ago

Original comment by bmcqu...@google.com on 25 Jan 2010 at 7:06