firstred / postnl-api-php

PostNL API PHP bindings
https://postnl-php.readthedocs.io
MIT License
26 stars 37 forks source link

confirm parameter should be `true` or `false` #57

Closed BBrunekreeft closed 1 year ago

BBrunekreeft commented 2 years ago

According to the PostNL Integrations helpdesk, the confirm parameter in the Labelling API should be true or false, not 0 or 1. confirm=0 wil actually confirm the label..

codecov[bot] commented 1 year ago

Codecov Report

Merging #57 (66f4b69) into v1.3.x (99e22c4) will increase coverage by 0.65%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/firstred/postnl-api-php/pull/57/graphs/tree.svg?width=650&height=150&src=pr&token=WdyfcT88x5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker)](https://codecov.io/gh/firstred/postnl-api-php/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) ```diff @@ Coverage Diff @@ ## v1.3.x #57 +/- ## ============================================ + Coverage 56.97% 57.62% +0.65% - Complexity 2026 2032 +6 ============================================ Files 114 114 Lines 5216 5112 -104 ============================================ - Hits 2972 2946 -26 + Misses 2244 2166 -78 ``` | [Impacted Files](https://codecov.io/gh/firstred/postnl-api-php/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) | Coverage Δ | | |---|---|---| | [src/Service/LabellingService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvTGFiZWxsaW5nU2VydmljZS5waHA=) | `86.09% <100.00%> (-0.62%)` | :arrow_down: | | [src/Util/Util.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1V0aWwvVXRpbC5waHA=) | `24.73% <0.00%> (-2.36%)` | :arrow_down: | | [src/Service/ShippingService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvU2hpcHBpbmdTZXJ2aWNlLnBocA==) | `89.18% <0.00%> (-1.06%)` | :arrow_down: | | [src/Service/DeliveryDateService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvRGVsaXZlcnlEYXRlU2VydmljZS5waHA=) | `79.82% <0.00%> (-0.50%)` | :arrow_down: | | [src/Service/ShippingStatusService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvU2hpcHBpbmdTdGF0dXNTZXJ2aWNlLnBocA==) | `53.95% <0.00%> (-0.48%)` | :arrow_down: | | [src/Service/LocationService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvTG9jYXRpb25TZXJ2aWNlLnBocA==) | `89.18% <0.00%> (-0.38%)` | :arrow_down: | | [src/Service/TimeframeService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvVGltZWZyYW1lU2VydmljZS5waHA=) | `89.28% <0.00%> (-0.37%)` | :arrow_down: | | [src/Service/BarcodeService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvQmFyY29kZVNlcnZpY2UucGhw) | `92.85% <0.00%> (-0.25%)` | :arrow_down: | | [src/Service/ConfirmingService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvQ29uZmlybWluZ1NlcnZpY2UucGhw) | `90.00% <0.00%> (-0.20%)` | :arrow_down: | | ... and [18 more](https://codecov.io/gh/firstred/postnl-api-php/pull/57/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/57?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/57?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Last update [99e22c4...66f4b69](https://codecov.io/gh/firstred/postnl-api-php/pull/57?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker).
firstred commented 1 year ago

Thanks a lot!