search

firstred / postnl-api-php

PostNL API PHP bindings
https://postnl-php.readthedocs.io
MIT License
26 stars 37 forks source link

Fix to retrieve DownPartnerID #60

Closed BBrunekreeft closed 2 years ago

BBrunekreeft commented 2 years ago

Calling getDownPartnerId() on a shipment response returns always null. Changes the method name to getDownPartnerID, to make this work. This fixes #59

codecov[bot] commented 2 years ago

Codecov Report

Merging #60 (d5e32a4) into v1.3.x (b2edfac) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/firstred/postnl-api-php/pull/60/graphs/tree.svg?width=650&height=150&src=pr&token=WdyfcT88x5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker)](https://codecov.io/gh/firstred/postnl-api-php/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) ```diff @@ Coverage Diff @@ ## v1.3.x #60 +/- ## ========================================= Coverage 57.62% 57.62% Complexity 2031 2031 ========================================= Files 114 114 Lines 5111 5111 ========================================= Hits 2945 2945 Misses 2166 2166 ``` | [Impacted Files](https://codecov.io/gh/firstred/postnl-api-php/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) | Coverage Δ | | |---|---|---| | [src/Entity/Response/ResponseShipment.php](https://codecov.io/gh/firstred/postnl-api-php/pull/60/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL0VudGl0eS9SZXNwb25zZS9SZXNwb25zZVNoaXBtZW50LnBocA==) | `100.00% <ø> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/60?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/60?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Last update [b2edfac...d5e32a4](https://codecov.io/gh/firstred/postnl-api-php/pull/60?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker).
firstred commented 2 years ago

Thanks a lot for the fix!