firstred / postnl-api-php

PostNL API PHP bindings
https://postnl-php.readthedocs.io
MIT License
26 stars 37 forks source link

fix: set Address property if it does not exists #73

Closed BBrunekreeft closed 1 year ago

BBrunekreeft commented 1 year ago

When retrieving the complete shipping status of a Smart Return label, there's no address in the response. This fix solves #72

codecov[bot] commented 1 year ago

Codecov Report

Merging #73 (473f685) into v1.3.x (994fd91) will decrease coverage by 0.18%. The diff coverage is 50.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/firstred/postnl-api-php/pull/73/graphs/tree.svg?width=650&height=150&src=pr&token=WdyfcT88x5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker)](https://codecov.io/gh/firstred/postnl-api-php/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) ```diff @@ Coverage Diff @@ ## v1.3.x #73 +/- ## ============================================ - Coverage 57.63% 57.45% -0.19% - Complexity 2033 2036 +3 ============================================ Files 114 114 Lines 5113 5103 -10 ============================================ - Hits 2947 2932 -15 - Misses 2166 2171 +5 ``` | [Impacted Files](https://codecov.io/gh/firstred/postnl-api-php/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) | Coverage Δ | | |---|---|---| | [src/Service/ShippingStatusService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvU2hpcHBpbmdTdGF0dXNTZXJ2aWNlLnBocA==) | `53.92% <50.00%> (-0.03%)` | :arrow_down: | | [src/Entity/Warning.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL0VudGl0eS9XYXJuaW5nLnBocA==) | `73.33% <0.00%> (-26.67%)` | :arrow_down: | | [src/Service/DeliveryDateService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvRGVsaXZlcnlEYXRlU2VydmljZS5waHA=) | `79.47% <0.00%> (-0.36%)` | :arrow_down: | | [src/Service/ConfirmingService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvQ29uZmlybWluZ1NlcnZpY2UucGhw) | `89.79% <0.00%> (-0.21%)` | :arrow_down: | | [src/Service/LocationService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvTG9jYXRpb25TZXJ2aWNlLnBocA==) | `88.99% <0.00%> (-0.20%)` | :arrow_down: | | [src/Service/LabellingService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvTGFiZWxsaW5nU2VydmljZS5waHA=) | `85.90% <0.00%> (-0.19%)` | :arrow_down: | | [src/Service/BarcodeService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvQmFyY29kZVNlcnZpY2UucGhw) | `92.68% <0.00%> (-0.18%)` | :arrow_down: | | [src/Service/TimeframeService.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL1NlcnZpY2UvVGltZWZyYW1lU2VydmljZS5waHA=) | `89.13% <0.00%> (-0.16%)` | :arrow_down: | | [src/HttpClient/CurlClient.php](https://codecov.io/gh/firstred/postnl-api-php/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker#diff-c3JjL0h0dHBDbGllbnQvQ3VybENsaWVudC5waHA=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/firstred/postnl-api-php/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Last update [994fd91...473f685](https://codecov.io/gh/firstred/postnl-api-php/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michael+Dekker).
firstred commented 1 year ago

Thank you very much!