search

firstrow / logvoyage

LogVoyage - logging SaaS written in GoLang
MIT License
94 stars 12 forks source link

Some improvements #12

Closed slayer closed 7 years ago

firstrow commented 8 years ago

Thanks for the PR. I will merge after test.

slayer commented 8 years ago

There is some problem with go get. WIth require "github.com/firstrow/logvoyage/..." I cant develop and push to github. With local require: requre "../commands" there are problems with CI and initial building.

firstrow commented 8 years ago

I think its good convention always to use full paths.

slayer commented 8 years ago

Maybe, but not for team work :(

firstrow commented 8 years ago

Why not good for team? As I see almost 99% uses full path.

bweston92 commented 8 years ago

I agree with @firstrow using full paths makes it easier. If you don't want it in your gopath then just symbolic link it to your development directory. How-ever there are some other improvements that are interesting in this PR especially docker as I just discovered this project and first thoughts was where is the docker package.

firstrow commented 8 years ago

@slayer: it would be nice if you remove raltive paths, so I can merge this one.

slayer commented 8 years ago

@firstrow ok

firstrow commented 7 years ago

thanks for contributing to project. project is no longer maintained. v2 will be out soon. check http://github.com/logvoyage for updates. thanks.

slayer commented 7 years ago

Cool. Will be waiting.

firstrow commented 7 years ago

https://github.com/logvoyage/logvoyage sorry, no docs for now, setup is easy, you can write me on irc/gitter if you are interested in contributions on this early stage.

firstrow commented 7 years ago

@slayer