search

firsttris / plugin.video.sendtokodi

:tv: plays various stream sites on kodi using youtube-dl
MIT License
125 stars 28 forks source link

replace deprecated function listItem.setInfo() #101

Open firsttris opened 10 months ago

firsttris commented 10 months ago

should fix: https://github.com/firsttris/plugin.video.sendtokodi/issues/92

nullket commented 10 months ago

I am currently not able to test the changes but based on quick research this will break support for everything before Kodi 20. But I am not 100 % certain, somebody else might want to clarify this. For me this would be welcomed as it would allow us to get rid of the python2 compatibility quirks (no second repo, using python3 features etc.) - but I am not the only one and there still might be people on 18/19. Just wanted to let you know :)

firsttris commented 9 months ago

for me its okay to move on now and drop python2.

nullket commented 9 months ago

Makes the most sense for me as well but maybe another PR should first get rid of the workflow etc. for the python2 repo? In that case the lost soul still using python2 could at least use the latest published addon until the resolver breaks due to website changes. Otherwise this pr would cause an update an break the addon for python2 immediately.

anohren commented 3 months ago

I'm that lost soul

Kodi 17.6 on Debian 10 on an 32 bit Intel Atom netbook with OpenGL 1.4 support. The perfect kitchen youtube player 🙂

What can I say? It's cute. This and ScummVM are its last hope (I even built Kodi 17.6 for Debian 10 for it). I guess I'll have to start hooking into the system's youtube-dl...

anohren commented 3 months ago

I wasn't going to bother suggesting this just for my old netbook, but I just noticed that all 32 bit iOS devices are stuck with Kodi 18. This includes iPads with retina screens.

If the goal is to simplify development (how much development is planned?) then maybe this repo can be forked into a Python 2 source repo that just runs automated updates of youtube-dl and nothing else? That'd preserve a strong use case of repurposing old iPads -- tablets that seriously can't even browse the web anymore because of outdated browsers and certificates. I think the convenience of sending videos to iPads would be a good way to keep them from becoming planned e-waste.

That wouldn't complicate any future development, would it?