firsttris / plugin.video.sendtokodi

:tv: plays various stream sites on kodi using youtube-dl
MIT License
121 stars 27 forks source link

MXPlayer not working #72

Closed GautamMKGarg closed 1 year ago

GautamMKGarg commented 1 year ago

Describe the bug mxplayer.in URLs are not getting played. Same URL is working fine with Yatse Android App but not working on Kore

To Reproduce Trying to play below url using Kore. Same URL is working fine on Yatse but not working on Kore. https://www.mxplayer.in/show/watch-aashram/season-1/duh-swapna-online-d445579792b0135598ba1bc9088a84cb

Expected behavior Video from above URL should be played

Kodi and sendtokodi version (please complete the following information):

Provide a Kodi log

2022-08-27 15:59:44.172 T:13112 INFO : JSONRPC Server: New connection added 2022-08-27 15:59:51.220 T:20756 INFO : initializing python engine. 2022-08-27 15:59:51.305 T:9708 INFO : Python interpreter stopped 2022-08-27 15:59:53.589 T:1308 INFO : CActiveAESink::OpenSink - initialize sink 2022-08-27 15:59:55.190 T:20756 ERROR : ERROR: [Mxplayer] d445579792b0135598ba1bc9088a84cb: Requested format is not available. Use --list-formats for a list of available formats

2022-08-27 15:59:55.195 T:20756 ERROR : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

2022-08-27 15:59:55.318 T:20756 INFO : Python interpreter stopped



**In case a certain website does not work for you**
- sendtokodi uses a third-party resolver to extract playable media URLs from your input
- You can choose between [youtube-dl](https://github.com/ytdl-org/youtube-dl) and [yt-dlp](https://github.com/yt-dlp/yt-dlp)
  - If you have not changed anything in the addon settings the default is yt-dlp for kodi 19 and above while it is youtube-dl for earlier versions 
- Please search their corresponding issue tracker and make sure that the issue is not already known there but an actual problem with sendtokodi
- In case they have an issue on the topic already, there is nothing we can do but wait. 
  - sendtokodi will automatically be updated as soon as they release a fix.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.
firsttris commented 1 year ago

i saw once at the yatse source code, that they are using other resolvers as youtube-dl. (also resolvers in the grey area)

GautamMKGarg commented 1 year ago

Hello

Thanks for reply. Yatse also started using yt-dlp. After debugging sendtokodi code, I found the issue. Few extractors of yt-dlp does not work with format "best" https://github.com/firsttris/plugin.video.sendtokodi/blob/baa5a2200ba13d4b87114df92c3982e02ae3fbcd/service.py#L162

instead of format "best" yt-dlp now suggest new method. Kindly refer below link https://github.com/yt-dlp/yt-dlp/blob/master/README.md#format-selection-examples

In yatse, they attempt to get video data twice, with two different format. Kindly refer url below. https://github.com/Tolriq/repository.yatse.kodi/blob/0e994240717d652c6fe84e0b40c2e418a1051492/script.yatse.kodi/lib/share.py#L108-L114

I think sendtokodi addon lacks code similar to the code of yatse given below https://github.com/Tolriq/repository.yatse.kodi/blob/0e994240717d652c6fe84e0b40c2e418a1051492/script.yatse.kodi/lib/share.py#L76-L90

what do you suggest?

GautamMKGarg commented 1 year ago

Hi @firsttris

Have you checked my last reply?

firsttris commented 1 year ago

hey @GautamMKGarg thx for your research! i really appreciate it.

i think we should improve this as well

do you have the motivation & skills to provide a Pull-Request?

best regards